fix(project): specify the corrent gettext domain in appstream file

Open zefr0x opened this issue 1 year ago • 1 comments

Description

The gettext text domain used in the application and the one which Meson installs to is bottles, but the one specified in the appstream file is com.usebottles.bottles

https://github.com/bottlesdevs/Bottles/blob/ed765a96599f9596d8010e57b25b3c4ed626a563/bottles/frontend/bottles.py#L36

https://github.com/bottlesdevs/Bottles/blob/ed765a96599f9596d8010e57b25b3c4ed626a563/bottles/frontend/main.py#L67-L70

https://github.com/bottlesdevs/Bottles/blob/ed765a96599f9596d8010e57b25b3c4ed626a563/data/com.usebottles.bottles.gschema.xml#L2

https://github.com/bottlesdevs/Bottles/blob/ed765a96599f9596d8010e57b25b3c4ed626a563/po/meson.build#L12

https://github.com/bottlesdevs/Bottles/blob/ed765a96599f9596d8010e57b25b3c4ed626a563/data/com.usebottles.bottles.metainfo.xml.in#L49

Also, should I instead change the gettext domain to com.usebottles.bottles in the application and Meson? I think it is best practice, but it might break the Weblate bot or something.

Type of change

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update