botocore icon indicating copy to clipboard operation
botocore copied to clipboard

Upgrade ruff, fix issues, use ruff for import sorting

Open akx opened this issue 9 months ago • 1 comments

This PR:

  • upgrades the version of Ruff used from 0.4.8 to 0.9.4
  • copies the exclude rules from pre-commit configuration to the Ruff configuration, to make it possible to run ruff outside of pre-commit
  • reapplies ruff format (mechanical)
  • fixes other new complaints surfaced by the new version of Ruff
  • gets rid of isort for import sorting in favor of just ruff's I rule.
    • This had some manual work go into it, to keep the context of the noqa comments intact.

akx avatar Feb 07 '25 06:02 akx

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Please upload report for BASE (develop@976b894). Learn more about missing BASE report. Report is 680 commits behind head on develop.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #3380   +/-   ##
==========================================
  Coverage           ?   93.03%           
==========================================
  Files              ?       66           
  Lines              ?    14452           
  Branches           ?        0           
==========================================
  Hits               ?    13446           
  Misses             ?     1006           
  Partials           ?        0           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov-commenter avatar Feb 07 '25 07:02 codecov-commenter

Well, looks like @nateprewitt did this work some 4 months later in #3495 😄

akx avatar Jul 22 '25 10:07 akx