simpleflow icon indicating copy to clipboard operation
simpleflow copied to clipboard

simpleflow.activity.Activity timeout arguments aren't optional

Open mprecise opened this issue 10 years ago • 1 comments

I created all of my activity types, workflow types, and domains manually in the AWS console before I began using simpleflow, so I have no experience trying to register these types using simpleflow. Since my types were pre-registered, I thought I'd be able to leave off all four of the timeout parameters when decorating an activity function with @simpleflow.activity.with_attributes. However, my decider received this error

  File "/usr/local/lib/python2.7/dist-packages/swf/actors/decider.py", line 53, in complete
    raise ResponseError(e.body['message'])
ResponseError: Invalid duration: None

Adding the timeouts to the decorator parameters fixed this. If these are indeed optional, I assume the fix is for the library to remove any keys whose value is None before making the request.

mprecise avatar Apr 15 '15 02:04 mprecise

The problem seems to come from https://github.com/botify-labs/python-simple-workflow. I created https://github.com/botify-labs/python-simple-workflow/issues/47 to fix it.

ggreg avatar Apr 19 '15 23:04 ggreg