Micah Geisel
Micah Geisel
Hi folks, I circled back around today to the newest 8.0 release to see if this had been fixed, but it appears the situation is worse now. I can't get...
@luke-hill From my brief experimentation, no, there has been further regression of the line number functionality. Every line number I tried resulted in 0 scenarios, and I tried line numbers...
@luke-hill @mattwynne Ah, I found the culprit. The scenario was tagged with a tag that was disabled by cucumber.yml in the environment that I was in while testing. So my...
@luke-hill @mattwynne Okay, I think I've tracked the issue it down to this method. https://github.com/cucumber/cucumber-ruby-core/blob/9b3c892c4056240be6542be05a2df6b5062b68e9/lib/cucumber/core/compiler.rb#L75 The private method `#source_lines_for_pickle` returns an array containing only the line number of the scenario...
Unsurprisingly, its not that simple. Too many other parts of cucumber are expecting the Test::Case's Location#lines to be only the Scenario line. I'm thinking the way forward is to add...
Okay, put up a POC PR over at cucumber-core. What do y'all think?
@mattwynne Ah, just now reviewing your comments from March 30th, 2021 about `Test::Case#match_locations?` and the fate of the relevant tests. I'll see if I can't resurrect those tests, and perhaps...
Hmm, so it seems to me the "right" thing to here is to fix `mkmf` to not pollute the global namespace. Since `mkmf` is in core, and this would have...
Thanks for doing the detective work on this, btw, @febeling !
https://bugs.ruby-lang.org/issues/12370