edamame icon indicating copy to clipboard operation
edamame copied to clipboard

Figure out if pushbackreader optimization by @chrisn helps

Open borkdude opened this issue 2 years ago • 3 comments

Port by @slipset: https://github.com/slipset/data.json/commits/with-char-reader @chrisn: https://github.com/cnuernber/charred/blob/master/java/charred/CharReader.java#L82

I don't know if clojure code needs to push back more than one character, I guess we'll figure out by trial and error, so let's be very careful before we use this in anything production.

borkdude avatar May 01 '23 12:05 borkdude

That's the wrong chrisn, you're looking for @cnuernber

slipset avatar May 01 '23 13:05 slipset

Whoops, sorry :)

borkdude avatar May 01 '23 13:05 borkdude

👋 😕

chrisn avatar May 01 '23 14:05 chrisn

It didn't really help since tools.reader already had its own pushback reader implementation

borkdude avatar Jul 05 '24 15:07 borkdude