gil
gil copied to clipboard
Improved 2D convolution and correlation
Description
Fixes #609 Fixes #610 Depends on #623
References
Tasklist
- [x] Add test case(s)
- [ ] Ensure all CI builds pass
- [ ] Review and approve
Script used for comprehensive testing is here and folder containing expected, source images for those tests is here.
@meshtag Could you tell what is the status of this PR? Is this going to be picked up or drop it and close it?
I will try to resolve merge conflicts and update this PR with latest version of the repository by the end of this weekend (will ping you once these PRs are ready for review). As far as usability is concerned, it was in a perfect working condition during my GSoC coding period. Same goes for #612 and #613 as well.
Sounds good. Yes, there has been lots of activity hence the conflicts. If you will have trouble with resolving them and need help, let me know.
Codecov Report
Merging #624 (c2c614d) into develop (843ea37) will decrease coverage by
3.61%. The diff coverage is12.45%.
@@ Coverage Diff @@
## develop #624 +/- ##
===========================================
- Coverage 78.76% 75.15% -3.62%
===========================================
Files 117 117
Lines 5030 5296 +266
===========================================
+ Hits 3962 3980 +18
- Misses 1068 1316 +248
@mloskot , I have resolved merge conflicts in above mentioned PRs but will have to obtain a closer look to examine why some CI builds are failing in this one. I'll try to do this in the coming week.