gil icon indicating copy to clipboard operation
gil copied to clipboard

Port TuttleOFX extension : aligned

Open meshtag opened this issue 4 years ago • 3 comments

Description

This pull request intends to port aligned extension from TuttleOFX repository to Gil as mentioned in #449 .

I have tried not to change anything significant in actual extension code. However, I have reformatted test cases completely in order to align them with current practices followed by Gil.

Tasklist

  • [x] Add test case(s)
  • [x] Ensure all CI builds pass
  • [ ] Review and approve

meshtag avatar Mar 17 '21 08:03 meshtag

Codecov Report

Merging #583 (d5ff162) into develop (bbdce36) will increase coverage by 0.02%. The diff coverage is 85.00%.

@@             Coverage Diff             @@
##           develop     #583      +/-   ##
===========================================
+ Coverage    78.72%   78.74%   +0.02%     
===========================================
  Files          118      119       +1     
  Lines         5034     5054      +20     
===========================================
+ Hits          3963     3980      +17     
- Misses        1071     1074       +3     

codecov[bot] avatar Apr 10 '21 06:04 codecov[bot]

@mloskot , I will have to examine this more clearly for figuring out why this PR builds successfully on some configurations and fails for others. Currently, I am a bit busy working on my GSoC proposal and kernel generation for Sobel operator. I will try to fix this again after 13th April 2021, hence marking this PR as draft for now.

meshtag avatar Apr 10 '21 07:04 meshtag

Absolutely no rush, take your time.

mloskot avatar Apr 10 '21 11:04 mloskot