geometry icon indicating copy to clipboard operation
geometry copied to clipboard

MSVC CI may not take effect

Open FantasqueX opened this issue 1 year ago • 5 comments
trafficstars

As you can see in the latest CI result, warning: Did not find command for MSVC toolset. If you have Visual Studio 2017 installed you will need to specify the full path to the command, set VS150COMNTOOLS for your installation, or build from the 'Visual Studio Command Prompt for VS 2017'. and no test is executed.

The problem is that there is no msvc-15 or msvc-16. MSVC supports c++14 from vs2015 a.k.a. msvc-14.0. b2_toolset should be

b2_toolset: [
  msvc-14.0,
  msvc-14.1,
  msvc-14.2,
  msvc-14.3,
]

FantasqueX avatar Dec 10 '23 13:12 FantasqueX

Thanks for opening this. It seems that msvc-14.0 -- msvc-14.2 return the same error (see https://github.com/boostorg/geometry/pull/1224). Probably there is a need for extra setting to make them work on CI.

vissarion avatar Dec 13 '23 10:12 vissarion

On my machine (Windows 11 with vs2019 installed), ./b2 toolset=msvc-14.2 works well. According to Github action documentation, both vc142 and vc143 of vs2022 are installed. I don't know why b2 cannot find vc142. Maybe some more investigation needs to be done.

FantasqueX avatar Dec 13 '23 13:12 FantasqueX