geometry icon indicating copy to clipboard operation
geometry copied to clipboard

Published 20 hours ago • verified publisher icon boostorg

Remove deprecated test-suite rule

Open FantasqueX opened this issue 1 year ago • 3 comments

According to https://github.com/bfgroup/b2/commit/597350653ada0f192dbe4b6d6ee509429f1cda45, b2 deprecated test-suite rule in 2007.

FantasqueX avatar Nov 19 '23 15:11 FantasqueX

Thanks for the review. The reason why I remove it instead of replacing with alias is that users can do the same thing using b2 test/algorithms/area. There is only one alias target in one directory.

Well, it's not that important. If you still think alias should be used, I'll change the PR.

FantasqueX avatar Dec 03 '23 12:12 FantasqueX

I agree that there is a workaround for calling all tests in a directory but it seems like a braking change. Also I am not sure that the commands in the circleCI script will be run after this change. Cf. https://github.com/boostorg/geometry/blob/develop/.circleci/config.yml#L77C74-L77C116

vissarion avatar Dec 04 '23 10:12 vissarion

Sorry for my carelessness. It is a breaking change at least for CI.

FantasqueX avatar Dec 04 '23 16:12 FantasqueX