Christopher Hiller

Results 550 comments of Christopher Hiller

@danielstjules or rather, at any rate: If **expect.js** is the only thing that doesn't throw `AssertionError`'s, and we start explicitly catching them in hooks, then nothing will really "break" per...

...and perhaps **expect.js** will start to throw them if we bug them about it

Furthermore, we could actually start looking for `AssertionError`s everywhere. We could attempt to _detect_ an `AssertionError` as well if the object has `actual` and `expected` properties. If **expect.js** has these...

(we might be already doing this)

Further, I think it'd be good to see a test which asserts the behavior works as intended.

>> Further, I think it'd be good to see a test which asserts the behavior works as intended. > See the changes to karma.conf.js, which adds headers to enable Trusted...

(AppVeyor is no longer building our PRs; I've removed it from the list of checks)

> I'm not 100% sure I follow. You'd like to see a test of native Trusted Types functionality? A test that only runs in Chromium browsers and would fail if...

@rictic are you able to continue on this PR?

I am unsure if this would be a breaking change. Ideally, it would not have any impact on consumers, but... you never know. @mochajs/core thoughts?