bobf
bobf
I've just deployed an app running Rails from this branch and set up an SES/SNS topic. Confirmation and receipt both appear to be working fine.
> Thanks for the PR! Here’s the first round of feedback. Thanks a lot for the feedback. I have addressed all of your points. I think there is only one...
> I still like @georgeclaghorn's idea of a separate ConfirmationsController. I also think that would force us to consider a model extraction. > > Here's my take on that. @kaspth...
@kaspth @georgeclaghorn Thanks both for the feedback. I have adapted Kasper's refactor and addressed a couple of issues. A couple of things I think worth noting: * The `Message` param...
@mwesigwa Thanks for the idea - I was tempted to select this option myself so I'm sure others will as well. I've updated with this commit: https://github.com/rails/rails/pull/39364/commits/809f53b9576684a6fbd985d957ca22689d10138e Let me know...
@georgeclaghorn Is there anything here that needs changing ? I have a conflict with the main branch but would rather wait until I had some feedback before fixing in case...
@chrisortman Are you sure you didn't enable raw message delivery ? Check the documentation change here: https://github.com/rails/rails/commit/809f53b9576684a6fbd985d957ca22689d10138e If you still think it's wrong then let me know and I'll take...
@chrisortman Thanks for confirming - that's certainly interesting. I'll see if I can set up a similar scenario over the weekend and hopefully we can find a way to be...
@chrisortman Thanks a lot - that's definitely helpful. I'm currently stuck doing work-work over the weekend but if I manage to get through my stack I'll certainly take a look....
@chrisortman if that is the case just let me know and I'm happy to merge whatever is needed to get the functionality added. Am too busy to do much coding...