temporal icon indicating copy to clipboard operation
temporal copied to clipboard

`UtcOffset` should reject when the offset is subminute precision.

Open nekevss opened this issue 9 months ago • 3 comments

The line this most likely should be applied is here. Although we should double check it isn't meant to be applied elsewhere.

For reference to the specification step, see ParseTimeZoneIdentifier step 4.b.

nekevss avatar Mar 02 '25 06:03 nekevss

To continue on the above introduction, this will require changes upstream to ixdtf.

Currently, ixdtf only has one UtfOffsetRecord, and this will probably need to be updated to an enum with a MinutePrecisionOffset and FullPrecisionOffset.

The reason being is that a string like 2025-03-02T08:58:00-06:00:00 with sub minute precision cannot be reliably differentiated from 2025-03-02T08:58:00-06:00.

nekevss avatar Mar 02 '25 15:03 nekevss

Are either of these PRs related? https://github.com/unicode-org/icu4x/pull/6283 https://github.com/unicode-org/icu4x/pull/6213

sffc avatar Apr 30 '25 16:04 sffc

Yep! I believe these are fixed upstream. I just haven't updated the version of ixdtf yet and pulled them in yet, which is all that remains to close this issue.

nekevss avatar Apr 30 '25 16:04 nekevss