boa icon indicating copy to clipboard operation
boa copied to clipboard

Implement `i128` to `JsValue` conversions

Open Razican opened this issue 3 years ago • 5 comments

We can currently convert most of Rust's basic types to JsValue, but since the i128 type was a late addition to Rust, we don't offer that conversion. You can implement it by checking how this is done for i64: https://github.com/boa-dev/boa/blob/e2630faf82a27e958d0ca6c9b1c81554bcc07ff3/boa_engine/src/value/mod.rs#L1003-L1008

Razican avatar Mar 22 '22 20:03 Razican

Just to be clear, you want to convert all i28 types to JsValue?

Shreyan11 avatar Mar 30 '22 05:03 Shreyan11

I'd like to work on this issue

ghost avatar Apr 10 '22 00:04 ghost

Could I work on this issue? It seems to have not been solved on main or the latest commit.

jonah-saltzman avatar Jun 25 '22 19:06 jonah-saltzman

I believe there's an open pull request for this: https://github.com/boa-dev/boa/pull/1971

lastmjs avatar Jun 25 '22 19:06 lastmjs

This will be handled in #2276.

Razican avatar Oct 10 '22 12:10 Razican