bnd icon indicating copy to clipboard operation
bnd copied to clipboard

WIP Upgrade bndtools to Eclipse 4.34 2024-12

Open chrisrueger opened this issue 8 months ago • 4 comments

Trying with 2024-12 and/or 2025-03

  • depends on https://github.com/bndtools/bnd/pull/6535
  • depends on https://github.com/bndtools/bnd/pull/6529 (Java21 packages for resolution)
  • Waiting for https://github.com/bndtools/bnd/pull/6537 until I can continue.

chrisrueger avatar Mar 24 '25 23:03 chrisrueger

Current status:

  • I can launch the bnd eclipse instance with Eclipse 4.34 2024-12
  • but still tests failing... mainly because changed dependencies e.g. which were part of of Eclipse 2022-09, but are not in 2024-12 anymore.
image

chrisrueger avatar Apr 02 '25 15:04 chrisrueger

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@kriegfrj You seem to be very familiar with all the JUnit Testcases stuff in bnd / bndtools. Bndtools can be started with the Eclipse 2024-12 just fine, but I cannot sort out how to get the testcases running. I think I got lost in all the JUnit versions since a lot of libs got updated or were removed in the newer Eclipse. So there is something messed up with different bundle (incompatible) versions loaded and classloading issues and what not.

Some tests are working, but I got there via trial and error and I always feel I'm not doing it right.

So I could need some support there. Maybe you see something in the errors https://github.com/bndtools/bnd/actions/runs/14252255522/job/39947564487?pr=6536 and have some pointers or thoughts.

Thanks

chrisrueger avatar Apr 03 '25 21:04 chrisrueger

@kriegfrj You seem to be very familiar with all the JUnit Testcases stuff in bnd / bndtools. Bndtools can be started with the Eclipse 2024-12 just fine, but I cannot sort out how to get the testcases running. I think I got lost in all the JUnit versions since a lot of libs got updated or were removed in the newer Eclipse. So there is something messed up with different bundle (incompatible) versions loaded and classloading issues and what not.

Some tests are working, but I got there via trial and error and I always feel I'm not doing it right.

So I could need some support there. Maybe you see something in the errors https://github.com/bndtools/bnd/actions/runs/14252255522/job/39947564487?pr=6536 and have some pointers or thoughts.

Thanks

Sorry, I have a lot going on and haven't been paying close attention to this recently.

I'm a bit rusty on the details, but I remember that these tests were a bit of a pain because they run inside an Eclipse instance which might have different JUnit on its classpath than the one you are trying to test against. Then the launchpad would include a version of JUnit in the framework-under-test that it launched, which might be different to both of those.

The error:

 # org.junit.platform.launcher.TestExecutionListener: org.junit.platform.launcher.listeners.UniqueIdTrackingListener not a subtype
    java.util.ServiceConfigurationError: org.junit.platform.launcher.TestExecutionListener: org.junit.platform.launcher.listeners.UniqueIdTrackingListener not a subtype

...seems to suggest that this is in that category. It seems that UniqueIdTrackingListener being run inside the launchpad framework is linked to a different version of the TestExecutionListener class.

I'll see if I can have a look in the next day or so.

kriegfrj avatar Jun 16 '25 07:06 kriegfrj