iTextSharp-LGPL-Core icon indicating copy to clipboard operation
iTextSharp-LGPL-Core copied to clipboard

Published 20 hours ago • verified publisher icon bmeredith

Make classes disposable

Open junalmeida opened this issue 4 years ago • 2 comments

Do you think it makes sense to inherit IDisposable to classes like PdfWriter, PdfReader, and others whenever makes sense? If you agree, willing to accept Pull requests?

junalmeida avatar Dec 01 '20 17:12 junalmeida

Hey @junalmeida, thanks for reaching out, I am certainly open and welcome to accepting to PRs!

What you say makes sense.

In regards to PdfWriter, from what I understand in later versions of ITextSharp, IDisposable was added to IDocListener which is where I would like to see it implemented as well if done.

bmeredith avatar Dec 01 '20 23:12 bmeredith

You can try the updated version https://github.com/VahidN/iTextSharp.LGPLv2.Core

VahidN avatar Jul 25 '23 04:07 VahidN