APatch icon indicating copy to clipboard operation
APatch copied to clipboard

Toastnotification when an app requests root

Open 4mede opened this issue 1 year ago • 5 comments

Is your feature request related to a problem?/你的请求是否与某个问题相关?

No.

Describe the solution you'd like/描述你想要的解决方案

I think Magisk implements this well. Ideally, users would be able to choose notifications, toasts, or nothing like on Magisk. Even if it's not on by default, I think it would be better than not having the option at all. For security reasons and so that new users know that they have to go to the app to enable superuser for an app to use root, I think this would be helpful.

Describe alternatives you've considered/描述您考虑过的备选方案

None.

Additional context/其他信息

No response

4mede avatar Nov 25 '24 00:11 4mede

Not have this option because like you write, go to the app to enable superuser for an app to use root, for that not have request root, so I think is not very useful option like that, because already we know in which app give root.

VisionR1 avatar Nov 25 '24 13:11 VisionR1

Yes, but it's helpful to know when an app is using root and when an app that doesn't have it requests it. What if an app is using root and you don't want it to? What if an app is using it in the background all the time and so you want to revoke its permission? You won't know if there's no toast. What if there's a bypass like this and an app gets root permission without you authorizing it?

4mede avatar Nov 25 '24 14:11 4mede

Yes, but it's helpful to know when an app is using root and when an app that doesn't have it requests it. What if an app is using root and you don't want it to? What if an app is using it in the background all the time and so you want to revoke its permission? You won't know if there's no toast. What if there's a bypass like this and an app gets root permission without you authorizing it?

Yeah, I get your point. I think this have fixed in latest Magisk, I don't know about APatch.

VisionR1 avatar Nov 25 '24 15:11 VisionR1

Yes, it's fixed, and I wasn't saying it applies to APatch. But a similar vulnerability could be found in APatch.

4mede avatar Nov 25 '24 16:11 4mede

Yes, it's fixed, and I wasn't saying it applies to APatch. But a similar vulnerability could be found in APatch.

Yeah, understand.

VisionR1 avatar Nov 25 '24 16:11 VisionR1