bluss

Results 723 comments of bluss

What do you think of #205? We could skip the ArrayVec parts since they are quite limited

Looks to be in the right direction, that's nice - I'll be a bit unreachable during the summer, but back in a bit

fmt::Write is already implemented for ArrayString, so that part's done. How would it work with Arrayvec? There's no precendent (Vec doesn't implement fmt::Write), but if it's explained, maybe it's a...

Yes, that looks good, we can do that for arrayvec

Now panic or not has nothing to do with it, you can already index arrayvec because it derefs to slice. If possible in a good way, we should impl Index...

Using extend or FromIterator would be idiomatic here too, so think the existing functionality is already quite good for the use case

Nothing blocks adding resize to arrayvec. Extend and FromIterator are the answer to the question of missed methods, though.

Fwiw, this benchmark shows that the extend loop is pretty good but it's running into that "SetLenOnDrop problem", where the alias analysis is not good enough. It's not managing to...

Fwiw, -Zmutable-noalias does not help with that problem. Will post a PR to improve .extend()

@pftbest Is it the interface of the method or the performance? #74 shows that the performance of extend seems good enough for the use case.