ping-viewer
ping-viewer copied to clipboard
bluerobotics
waterfallplot: Use OpenGL
@patrickelectric are you still encountering the aberrations on the left edge of the plot?
@jaxxzer did you take a look in the video ? You can see it in the left corner. My idea is to merge this and fix this issue, right now this patch reduce the cpu usage dramatically
Yes I saw the problems that you mentioned in the past in the video, I thought it might have been fixed but an old video.
My idea is to merge this and fix this issue, right now this patch reduce the cpu usage dramatically
I'm hesitant to approve it in that case. I would prefer no graphical errors vs cpu usage (must have vs nice to have IMO). You know better than I what it will take to correct the problems after merge. I'll leave this to your judgement as maintainer.
@jaxxzer this PR is a intermediate step to make both waterfallplot and polarplot full OpenGL and remove the QML elements (like the shadereffect). Moving waterfallplot to this final version will require a bigger code change for both waterfallplot and polarplot making this patch much worst to review. If you agree please merge, otherwise it'll not be a simple patch as it's already.
The final PR is already in progress based in this changes and the last version of polarplot.