NimData icon indicating copy to clipboard operation
NimData copied to clipboard

Feature/from files

Open bflanders opened this issue 6 years ago • 4 comments

New to nim...was looking for a way to create one DF from files adhering to a pattern. I am working with a directory of files where one file = one DF, and I want to "append" them all together. I tried to make "fromFiles" repeatedly yield from a walkPattern iterator that repeatedly calls "fromFile", but I couldn't get that to work because I suck at nim.

I wanted offer a very small (albeit incomplete) addition and get feedback on what I did. Is there a more efficient way? Is this not idiomatic nim? Is there a more straightforward approach? I figured someone would get the gist of what I am doing and say "wtf, why would you do it like that?" and offer a better solution.

Overall, great code and easy to read! Very helpful library! Just trying to help...

bflanders avatar Nov 23 '19 19:11 bflanders

Hey, thanks for contributing! Just want to let you know that I will only be back in ~2 weeks to really have a look into this.

bluenote10 avatar Nov 24 '19 21:11 bluenote10

@bluenote10 did you make it back? Nov 2019...?

root-11 avatar Apr 20 '23 15:04 root-11

Oh sorry I completely forgot about that one.

I don't know, should we just merge it or is it no longer valid? I'm not actively using Nim any more, and I don't have the capacity to really maintain this (and without a proper CI it is hard to judge).

bluenote10 avatar Apr 21 '23 06:04 bluenote10

I've sent you a linkedin message for a more private conversation.

root-11 avatar Apr 21 '23 13:04 root-11