Meetup-API-client-for-PHP icon indicating copy to clipboard operation
Meetup-API-client-for-PHP copied to clipboard

Published 20 hours ago • verified publisher icon blobaugh

Update MeetupApiRequest.class.php

Open php-novice opened this issue 13 years ago • 3 comments

you mention query in your notes, but it was missing from the source.

php-novice avatar Oct 03 '12 12:10 php-novice

Sorry, where is query() mentioned? I could not find it on the wiki.

Your code is an easy shortcut, and I see no reason why not to have something like that, however I am on the fence as to whether it should be implemented as this.

I will put some thought into it. Anyone else have pros/cons?

blobaugh avatar Oct 03 '12 23:10 blobaugh

query() method is mentioned in the README line 66 as of blobaugh:master:6307311aaf

tmarkson avatar Nov 11 '12 05:11 tmarkson

Ah, I see now. I looked in the readme, my bad. There is also this wiki page

https://github.com/blobaugh/Meetup-API-client-for-PHP/wiki/Making-direct-Api-calls

Your solution is a decent shortcut, however you should return the entire response object, rather than the results. Let the devs chose how to handle it

blobaugh avatar Nov 27 '12 04:11 blobaugh