blag

Because we use multi-stage builds, I don't know that removing the duplicate `ARG` directives is going to solve this issue. From the [Docker documentation on `ARG`](https://docs.docker.com/engine/reference/builder/#scope): > An ARG instruction...

Just to color in my thoughts on the private methods in the dataset manager - I made them private only because I was trying to keep the dataset manager public...

My personal preference would be to pass around the `DatasetModel` and `DatasetEvent` objects directly, since that just seems cleaner to me. If/when we publicize more/all of the dataset manager methods...

Ease of testing is a perfectly valid and good reason. You've convinced me. 😄 And yeah, I was thinking the dataset event would be the last of all of the...

Updated description with screenshots and giving credit where credit is due.

@bbovenzi I fixed the issues with the aggregate counts (on PostgreSQL) and expanded the tests a little bit to include more DAG dataset relationships to exercise those SQL paths. Still...

> I haven't had a chance to move to 2.4.0 yet. Is there a way to filter datasets by tags, potentially? No, we haven't implemented tagging datasets yet. That's a...

This looks amazing, I'm excited for it! Thank you!

Is `core.dataset_event_manager_class` the right place in the configuration to put this setting?

Oh, and it would be nice to document the two templates that you've introduced: * `account/admin_approval_sent.html` * `account/ajax/admin_approval_sent.html` Edit: Deleted duplicate comment - sorry!