react-native-twilio-video-webrtc icon indicating copy to clipboard operation
react-native-twilio-video-webrtc copied to clipboard

Published 20 hours ago • verified publisher icon blackuy

Android X support

Open munjo5746 opened this issue 3 years ago • 3 comments

Steps to reproduce

  1. Setup react-native-twilio-video-webrtc on expo project with custom plugins.
  2. Run EAS build for android.

Expected behaviour

The android app built on EAS.

Actual behaviour

Build fails with error message, symbol: class NonNull

Environment

  • Node.js version: 16.13.2
  • React Native version: 0.64.3
  • React Native platform + platform version: Android

react-native-twilio-video-webrtc

Version: npm version or "master"

munjo5746 avatar Aug 17 '22 22:08 munjo5746

Will there be any chance this PR gets merged??

munjo5746 avatar Aug 17 '22 22:08 munjo5746

There are some changes requested on that PR. If you have the bandwidth to update it with the requested changes, I'd be happy to merge!

slycoder avatar Aug 18 '22 03:08 slycoder

There are some changes requested on that PR. If you have the bandwidth to update it with the requested changes, I'd be happy to merge!

I have added PR with requested changes, PR. Please let me know if there are additional changes required. @slycoder

munjo5746 avatar Sep 24 '22 05:09 munjo5746