react-native-twilio-video-webrtc icon indicating copy to clipboard operation
react-native-twilio-video-webrtc copied to clipboard

onParticipantAddedVideoTrack does not fire if participant joins from safari browser

Open AireshBhat opened this issue 4 years ago • 7 comments

Steps to reproduce

  1. Have one participant join from a safari browser.
  2. Have the other participant join from an android device

Expected behaviour

The browser participants video should stream on the android device

Actual behaviour

The video of the participant from the from the safari browser does not stream to the android device. Audio is present.

Environment

  • Node.js version: v12.18.3
  • React Native version: 0.64.0
  • React version: 17.0.0

react-native-twilio-video-webrtc

Version: master

AireshBhat avatar May 25 '21 11:05 AireshBhat

If this only applies to Safari then it might be a codec issue; please consult https://www.twilio.com/docs/video/managing-codecs to verify that the codecs are set up in a way that is compatible.

slycoder avatar May 29 '21 06:05 slycoder

I think this PR is causing issue. I fixed "the android video not sending to iOS issue" with using old code.

zuhairnaqi avatar Aug 09 '21 13:08 zuhairnaqi

@zuhairnaqi , interesting. That code shouldn't be doing anything to the video received by the android app; it only changed what the android app publishes. Do you have more info on the specific version which fixed the issue?

slycoder avatar Aug 19 '21 07:08 slycoder

I'm using old code which has a version "version": "2.0.0"

zuhairnaqi avatar Aug 19 '21 07:08 zuhairnaqi

Hi @slycoder, I'm using the code till this branch merged PR-440. And the issue is not occurring in it.

zuhairnaqi avatar Aug 19 '21 07:08 zuhairnaqi

Also, I have a request, kindly maintain a release version, because every time update came and things get changed

zuhairnaqi avatar Aug 19 '21 08:08 zuhairnaqi

Point well taken, once things stabilize a bit I'll push 2.1.0. I've created a tracking issue: #542

slycoder avatar Aug 21 '21 14:08 slycoder