react-native-twilio-video-webrtc icon indicating copy to clipboard operation
react-native-twilio-video-webrtc copied to clipboard

Camera2Capturer + onCameraSwitched fix (Android)

Open marqroldan opened this issue 4 years ago • 2 comments

This should be merged after #452 (I'm assuming this PR gets squashed on merge)

This adds Camera2Capturer based on https://github.com/twilio/video-quickstart-android/blob/master/quickstart/src/main/java/com/twilio/video/quickstart/util/CameraCapturerCompat.java

Tested on the following:

  • (Simulator) Android 4.4 (Google APIs)
  • (Simulator) Android 10.0 (Google APIs)
  • (SM-A715F) Android 11

Changes:

  • AndroidX was added
import androidx.annotation.NonNull;
import androidx.annotation.StringDef;
import androidx.annotation.RequiresApi;
  • ON_CAMERA_SWITCHED now happens on the camera listener's onCameraSwitched event
  • isBackCamera boolean also shows up on onConnected event
  • Addition and usage of Camera2Capturer by default based on API level

marqroldan avatar Apr 02 '21 17:04 marqroldan

@marqroldan Ok I've merged in #452, you should be able to merge master into this branch now.

slycoder avatar Apr 10 '21 19:04 slycoder

I think I haven't updated the types yet, I shall do that within 24 hours

marqroldan avatar Apr 11 '21 12:04 marqroldan