react-native-twilio-video-webrtc icon indicating copy to clipboard operation
react-native-twilio-video-webrtc copied to clipboard

Published 20 hours ago • verified publisher icon blackuy

Torch feature for Android and iOS

Open marqroldan opened this issue 4 years ago • 2 comments

They don't seem to break on iOS 12 and Android 10, these are the only devices that I have at the moment.

marqroldan avatar Mar 09 '21 14:03 marqroldan

The Android implementation doesn't work if used with https://github.com/blackuy/react-native-twilio-video-webrtc/pull/452

Most likely affect devices that have multiple back-facing camera (I'm using SM-A715F)

Possibly because of the way the back camera is obtained (it loops until the last camera) + uses Camera1 API

marqroldan avatar Mar 29 '21 08:03 marqroldan

Given that #452 has been merged is it just a minor change to the camera capturer logic to get it to work?

I wonder if moving to camera2 will allow third parties to manipulate the torch without embedding it into this library? If so maybe the right solution is to bite the bullet and do that upgrade instead.

slycoder avatar Apr 26 '21 01:04 slycoder