Bailey Thompson

Results 21 comments of Bailey Thompson

@master0v is there some logic to this (can it be computed), or do they randomly decide to change them?

@dr-prodigy this is probably related to Colombia, which is now fixed in 0.15

@jdamata I am interested in this functionality. Is this PR ready to be reviewed or are more changes required?

Ok sounds good thanks. @jdamata just to confirm, when the flag is enabled, stats are created as if the config had each value in it for each value matched?

Like lets say the config has descriptors: key: user rate_limit: ... And user a and b both match, then the stats will be domain.user.a.total_hits and domain.user.b.total_hits, etc ?

@mattklein123 @ysawa0 could one of you take a look at this PR please (to rerun the tests since the logs have been deleted)?

@jdamata could you rebase from main please so the build checks pass? Thanks. Also, if you need help fixing the tests let me know.

@jdamata you might need to force push with "Signed-off-by: Joel Damata " as the commit message since the last commit didn't have it making the DCO check fail.

@jdamata Just wanted to follow up on this. Could you force push to get DCO to pass? You'll have to also make the PR be from your feature branch to...

@jdamata looks good! Could check that failing test? I think it's formatting issues. Thanks.