vscode-tcl icon indicating copy to clipboard operation
vscode-tcl copied to clipboard

broken syntax highlighting

Open tzwaenn opened this issue 1 year ago • 4 comments

if {[regexp {([^[]+)[([^]]+)]} a]} {} leads to image

tzwaenn avatar Dec 06 '24 10:12 tzwaenn

Another example: dict create k1 v1 k2 "(different value)" highlight

tzwaenn avatar Dec 12 '24 16:12 tzwaenn

Thank you, when I have a time slice I'll take a look, but that may be some time away. In the mean time feel free to take a crack at it

bitwisecook avatar Dec 24 '24 15:12 bitwisecook

Hey @bitwisecook, the other day I was playing locally with tests coverage for this repo for syntax with https://github.com/PanAeon/vscode-tmgrammar-test. It does a pretty great job.

Would you be interested in getting some coverage for these syntax issues?

maciejmatczak avatar Dec 25 '24 07:12 maciejmatczak

Absolutely, I personally have little time to work on this stuff at the moment, so I would be happy to accept PRs from anyone who'd like to contribute to tests or fixes. I can definitely recommend cooking up some simple test cases then using an LLM to translate more tests from the Tcl test sources in https://core.tcl-lang.org/tcl/file?name=tests/parse.test&ci=tip

bitwisecook avatar Dec 25 '24 09:12 bitwisecook