server icon indicating copy to clipboard operation
server copied to clipboard

Auth/PM-11252 - Registration with Email Verification - Adjust url to point to new signup redirect connector

Open JaredSnider-Bitwarden opened this issue 1 year ago â€ĸ 2 comments

đŸŽŸī¸ Tracking

https://bitwarden.atlassian.net/browse/PM-11252 Clients PR: https://github.com/bitwarden/clients/pull/10682

📔 Objective

To use a connector to redirect the user to continue the registration process so that Android can intercept the URL (it can't contain a hash since that is reserved on Android).

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

đŸĻŽ Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or â„šī¸ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or âš ī¸ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or â™ģī¸ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

JaredSnider-Bitwarden avatar Aug 22 '24 20:08 JaredSnider-Bitwarden

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 41.78%. Comparing base (8ab19c7) to head (520c0bf). Report is 68 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4691   +/-   ##
=======================================
  Coverage   41.78%   41.78%           
=======================================
  Files        1287     1287           
  Lines       60953    60953           
  Branches     5603     5603           
=======================================
  Hits        25472    25472           
  Misses      34293    34293           
  Partials     1188     1188           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Aug 22 '24 20:08 codecov[bot]

Logo Checkmarx One – Scan Summary & Details – f617131a-632a-460a-aa28-7396cf11e329

No New Or Fixed Issues Found

github-actions[bot] avatar Aug 22 '24 20:08 github-actions[bot]

~This may be on the radar already but it this goes in, may want to roll the same treatment to the "/signup-link-expired" path as well.~

Discussed async, above comment is moot. mobile client will handle token verification to route to correct screen.

dseverns-livefront avatar Aug 30 '24 13:08 dseverns-livefront

Passed QA

JaredSnider-Bitwarden avatar Sep 10 '24 15:09 JaredSnider-Bitwarden