Auth/PM-11252 - Registration with Email Verification - Adjust url to point to new signup redirect connector
đī¸ Tracking
https://bitwarden.atlassian.net/browse/PM-11252 Clients PR: https://github.com/bitwarden/clients/pull/10682
đ Objective
To use a connector to redirect the user to continue the registration process so that Android can intercept the URL (it can't contain a hash since that is reserved on Android).
â° Reminders before review
- Contributor guidelines followed
- All formatters and local linters executed and passed
- Written new unit and / or integration tests where applicable
- Protected functional changes with optionality (feature flags)
- Used internationalization (i18n) for all UI strings
- CI builds passed
- Communicated to DevOps any deployment requirements
- Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team
đĻŽ Reviewer guidelines
- đ (
:+1:) or similar for great changes - đ (
:memo:) or âšī¸ (:information_source:) for notes or general info - â (
:question:) for questions - đ¤ (
:thinking:) or đ (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - đ¨ (
:art:) for suggestions / improvements - â (
:x:) or â ī¸ (:warning:) for more significant problems or concerns needing attention - đą (
:seedling:) or âģī¸ (:recycle:) for future improvements or indications of technical debt - â (
:pick:) for minor or nitpick changes
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 41.78%. Comparing base (
8ab19c7) to head (520c0bf). Report is 68 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #4691 +/- ##
=======================================
Coverage 41.78% 41.78%
=======================================
Files 1287 1287
Lines 60953 60953
Branches 5603 5603
=======================================
Hits 25472 25472
Misses 34293 34293
Partials 1188 1188
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Checkmarx One â Scan Summary & Details â f617131a-632a-460a-aa28-7396cf11e329
No New Or Fixed Issues Found
~This may be on the radar already but it this goes in, may want to roll the same treatment to the "/signup-link-expired" path as well.~
Discussed async, above comment is moot. mobile client will handle token verification to route to correct screen.
Passed QA