server icon indicating copy to clipboard operation
server copied to clipboard

[PM-10454] Improved code readability

Open Sala-Sergiu opened this issue 1 year ago â€ĸ 2 comments

đŸŽŸī¸ Tracking

📔 Objective

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

đŸĻŽ Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or â„šī¸ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or âš ī¸ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or â™ģī¸ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Sala-Sergiu avatar Aug 01 '24 15:08 Sala-Sergiu

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Aug 01 '24 15:08 CLAassistant

Thank you for your contribution! We've added this to our internal Community PR board for review. ID: PM-10454

bitwarden-bot avatar Aug 01 '24 15:08 bitwarden-bot

@Sala-Sergiu apologies that we did not review this in a more timely manner. I'm closing due to the age of the PR.

micahblut avatar Nov 12 '25 10:11 micahblut