server icon indicating copy to clipboard operation
server copied to clipboard

[PM-3833] Remove deprecated register and prelogin from API

Open Hinton opened this issue 2 years ago • 1 comments

Type of change

- [ ] Bug fix
- [ ] New feature development
- [x] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Remove the deprecated register and prelogin endpoints from the API service. I also moved the request and responses into the identity project and removed the duplicated test.

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • If making database changes - make sure you also update Entity Framework queries and/or migrations
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

Hinton avatar Sep 08 '23 12:09 Hinton

Logo Checkmarx One – Scan Summary & Details964b88f9-8e65-440a-a49e-ffb972d8d537

Fixed Issues

Severity Issue Source File / Package Checkmarx Insight
MEDIUM Privacy_Violation /src/Core/Services/Implementations/UserService.cs: 323 Attack Vector

bitwarden-bot avatar Sep 08 '23 12:09 bitwarden-bot

Closing this in favor of #4206.

JaredSnider-Bitwarden avatar Jun 19 '24 18:06 JaredSnider-Bitwarden