sdk icon indicating copy to clipboard operation
sdk copied to clipboard

[PM-5635] Support rustls-platform-verifier on Android

Open dani-garcia opened this issue 1 year ago • 2 comments
trafficstars

Type of change

- [ ] Bug fix
- [ ] New feature development
- [x] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Support rustls-platform-verifier on Android, I still have some errors with some self signed certificates left to investigate, but it works already with valid certificates.

dani-garcia avatar Feb 28 '24 18:02 dani-garcia

Codecov Report

Attention: Patch coverage is 20.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 57.99%. Comparing base (9134e98) to head (1b61f8e). Report is 1 commits behind head on main.

Files Patch % Lines
crates/bitwarden-uniffi/src/lib.rs 0.00% 4 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #639      +/-   ##
==========================================
- Coverage   58.01%   57.99%   -0.02%     
==========================================
  Files         197      197              
  Lines       13640    13644       +4     
==========================================
  Hits         7913     7913              
- Misses       5727     5731       +4     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Feb 28 '24 18:02 codecov[bot]

Logo Checkmarx One – Scan Summary & Details0cd20f98-9a2e-4882-bd35-9324d13f089d

No New Or Fixed Issues Found

bitwarden-bot avatar Feb 28 '24 18:02 bitwarden-bot

Do we need to document what settings are required on the app side?

The only setting needed is the network security config xml, and only if you want to use self signed certificates. The android app is using them already, so they shouldn't require any changes: https://github.com/bitwarden/android/blob/main/app/src/main/res/xml/network_security_config.xml

(They are not disabling self signed certs for bitwarden.eu, though)

I'll mention in in the readme for bitwarden-uniffi and in the Kotlin code example.

dani-garcia avatar Aug 20 '24 12:08 dani-garcia