sdk icon indicating copy to clipboard operation
sdk copied to clipboard

SM-1096: Refactor state_file_path and others to state_path

Open coltonhurst opened this issue 1 year ago • 2 comments
trafficstars

Type of change

- [ ] Bug fix
- [ ] New feature development
- [x] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Code changes

  • file.ext: Description of what was changed and why

Before you submit

  • Please add unit tests where it makes sense to do so

coltonhurst avatar Feb 06 '24 01:02 coltonhurst

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

Comparison is base (69a5d7b) 53.77% compared to head (75db990) 53.77%. Report is 3 commits behind head on main.

Files Patch % Lines
crates/bitwarden/src/auth/login/access_token.rs 37.50% 5 Missing :warning:
crates/bitwarden/src/auth/renew.rs 0.00% 4 Missing :warning:
crates/bitwarden/src/secrets_manager/state.rs 0.00% 4 Missing :warning:
crates/bws/src/main.rs 0.00% 2 Missing :warning:
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #587   +/-   ##
=======================================
  Coverage   53.77%   53.77%           
=======================================
  Files         165      165           
  Lines        8878     8878           
=======================================
  Hits         4774     4774           
  Misses       4104     4104           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Feb 06 '24 01:02 codecov[bot]

Logo Checkmarx One – Scan Summary & Details0676a9c3-a670-4467-a670-931ef0801aba

No New Or Fixed Issues Found

bitwarden-bot avatar Feb 06 '24 19:02 bitwarden-bot

Closing in favor of new sm/sm-1096 PR: https://github.com/bitwarden/sdk/pull/895

coltonhurst avatar Jul 10 '24 20:07 coltonhurst