mobile icon indicating copy to clipboard operation
mobile copied to clipboard

[PS-1228] Android: Label of terms of service and privacy policy switch is too close to the actual switch in the sign-up screen

Open deividt opened this issue 3 years ago • 1 comments
trafficstars

Type of change

  • [x] Bug fix
  • [ ] New feature development
  • [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • [ ] Build/deploy pipeline (DevOps)
  • [ ] Other

Objective

This PR fixes the #2009 issue. It adds a margin between the switch and the privacy policy text in the sign-up screen.

Code changes

  • RegisterPage.xaml: Removed the binding property for the margin and changed to a fixed value. Since I haven't found any style for the switch, I kept the definition here.
  • RegisterPageViewModel.xaml: Since now the value is the same for iOS and Android, the property is no longer necessary.

Screenshots

Screenshot_1659324516

Before you submit

  • [x] I have checked for formatting errors (dotnet tool run dotnet-format --check) (required)
  • [ ] I have added unit tests where it makes sense to do so (encouraged but not required)
  • [ ] This change requires a documentation update (notify the documentation team)
  • [ ] This change has particular deployment requirements (notify the DevOps team)

deividt avatar Aug 01 '22 03:08 deividt

Thank you for your contribution! We've added this to our internal Community PR board for review. ID: PS-1228

bitwarden-bot avatar Aug 01 '22 03:08 bitwarden-bot

This looks good, I'm merging it. It will be part of an upcoming release. Thank you for the contribution!

aj-rosado avatar Aug 16 '22 17:08 aj-rosado