contributing-docs icon indicating copy to clipboard operation
contributing-docs copied to clipboard

add devcontainer setup docs

Open tangowithfoxtrot opened this issue 2 years ago • 7 comments
trafficstars

Objective

This adds documentation for VS Code Dev Containers, added by the associated PR in server.

tangowithfoxtrot avatar Jul 12 '23 16:07 tangowithfoxtrot

Logo Checkmarx One – Scan Summary & Details5035d625-d5c4-4950-9182-d115a710098d

No New Or Fixed Issues Found

bitwarden-bot avatar Jul 12 '23 16:07 bitwarden-bot

I am not sure why the build workflow is having issues with the link used in the docs; the link works locally and is a direct copy from the standard "Setup Guide" steps.

tangowithfoxtrot avatar Jul 12 '23 17:07 tangowithfoxtrot

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: f3909e0
Status: ✅  Deploy successful!
Preview URL: https://a768163d.contributing-docs.pages.dev
Branch Preview URL: https://vscode-devcontainers.contributing-docs.pages.dev

View logs

@tangowithfoxtrot my other comment may have been missed -- link errors are blocking the build.

withinfocus avatar Jul 12 '23 18:07 withinfocus

@withinfocus My bad. I did miss your comment there. I can look into an alternative link format, but I'm confused as to why the build workflow would claim that it's broken, as it's a direct copy from the existing "Setup Guide" doc ~~and works with my local build.~~

tangowithfoxtrot avatar Jul 12 '23 19:07 tangowithfoxtrot

~as it's a direct copy from the existing "Setup Guide" doc and works with my local build.~

Whoops. That was incorrect 😁 Looking into it now...

tangowithfoxtrot avatar Jul 12 '23 19:07 tangowithfoxtrot

With https://github.com/bitwarden/server/pull/3080 landed should we look at this again?

withinfocus avatar Dec 12 '23 16:12 withinfocus