clients icon indicating copy to clipboard operation
clients copied to clipboard

[PM-5270] Update PasswordResetEnrollmentService to take dependency on AccountService

Open rr-bw opened this issue 1 year ago • 1 comments

Type of change

  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)

Objective

Update PasswordResetEnrollmentService to take dependency on AccountService for the userId.

Code changes

  • file.ext: Description of what was changed and why

Screenshots

Before you submit

  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team
  • Ensure that all UI additions follow WCAG AA requirements

rr-bw avatar Feb 23 '24 23:02 rr-bw

Logo Checkmarx One – Scan Summary & Detailsa3fc4f94-8169-47a5-ab5d-06cd077ef856

New Issues

Severity Issue Source File / Package Checkmarx Insight
LOW Client_DOM_Open_Redirect /apps/desktop/src/auth/accessibility-cookie.component.html: 18 Attack Vector
LOW Unsafe_Use_Of_Target_blank /apps/desktop/src/auth/accessibility-cookie.component.ts: 92 Attack Vector

Fixed Issues

Severity Issue Source File / Package
LOW Client_DOM_Open_Redirect /apps/desktop/src/auth/accessibility-cookie.component.html: 18
LOW Client_Password_In_Comment /libs/common/src/state-migrations/migrations/30-move-policy-state-to-state-provider.ts: 13

bitwarden-bot avatar Feb 24 '24 00:02 bitwarden-bot

Codecov Report

Attention: Patch coverage is 75.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 25.37%. Comparing base (73504d9) to head (8713038). Report is 15 commits behind head on main.

Files Patch % Lines
...assword-reset-enrollment.service.implementation.ts 75.00% 0 Missing and 1 partial :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8080      +/-   ##
==========================================
+ Coverage   25.34%   25.37%   +0.02%     
==========================================
  Files        2259     2260       +1     
  Lines       66017    66029      +12     
  Branches    12421    12427       +6     
==========================================
+ Hits        16735    16757      +22     
+ Misses      47937    47921      -16     
- Partials     1345     1351       +6     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Mar 08 '24 23:03 codecov[bot]