clients icon indicating copy to clipboard operation
clients copied to clipboard

Move fingerprint validated to biometric state povider

Open MGibson1 opened this issue 1 year ago • 1 comments
trafficstars

Type of change

- [ ] Bug fix
- [x] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Finishes migration of biometric state to state poviders

Draft reason

awaiting upstream PRs and re-targeting to main

Code changes

  • file.ext: Description of what was changed and why

Screenshots

Before you submit

  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team
  • Ensure that all UI additions follow WCAG AA requirements

MGibson1 avatar Feb 22 '24 22:02 MGibson1

Codecov Report

Attention: Patch coverage is 50.00000% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 25.16%. Comparing base (d0e9978) to head (b1d1ad4). Report is 18 commits behind head on main.

Files Patch % Lines
...owser/src/background/nativeMessaging.background.ts 0.00% 2 Missing :warning:
...ibs/common/src/platform/services/system.service.ts 0.00% 2 Missing :warning:
...s/browser/src/popup/settings/settings.component.ts 0.00% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8058      +/-   ##
==========================================
+ Coverage   25.05%   25.16%   +0.10%     
==========================================
  Files        2246     2252       +6     
  Lines       65773    65849      +76     
  Branches    12404    12413       +9     
==========================================
+ Hits        16481    16571      +90     
+ Misses      47952    47936      -16     
- Partials     1340     1342       +2     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Feb 22 '24 22:02 codecov[bot]

Logo Checkmarx One – Scan Summary & Detailse0b2d1a5-b13e-49c8-b112-b5df69b0fa39

New Issues

Severity Issue Source File / Package Checkmarx Insight
MEDIUM Unpinned Actions Full Length Commit SHA /build-desktop.yml: 1280 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /build-cli.yml: 388 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /build-web.yml: 361 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /build-browser.yml: 426 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...

Fixed Issues

Severity Issue Source File / Package
MEDIUM Unpinned Actions Full Length Commit SHA /build-browser.yml: 409
MEDIUM Unpinned Actions Full Length Commit SHA /build-web.yml: 342
MEDIUM Unpinned Actions Full Length Commit SHA /build-cli.yml: 377
MEDIUM Unpinned Actions Full Length Commit SHA /build-desktop.yml: 1251

bitwarden-bot avatar Mar 04 '24 22:03 bitwarden-bot