clients icon indicating copy to clipboard operation
clients copied to clipboard

Published 20 hours ago • verified publisher icon bitwarden

[PM-2637] Refactor EnvironmentService

Open Hinton opened this issue 1 year ago • 2 comments
trafficstars

Type of change

- [ ] Bug fix
- [ ] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Code changes

  • file.ext: Description of what was changed and why

Screenshots

Before you submit

  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team
  • Ensure that all UI additions follow WCAG AA requirements

Hinton avatar Feb 22 '24 09:02 Hinton

Codecov Report

Attention: Patch coverage is 43.68132% with 205 lines in your changes are missing coverage. Please review.

Project coverage is 26.29%. Comparing base (2111b37) to head (05188fd).

Files Patch % Lines
...gular/src/auth/components/environment.component.ts 0.00% 18 Missing :warning:
...ps/web/src/app/platform/web-environment.service.ts 21.05% 15 Missing :warning:
...c/platform/services/default-environment.service.ts 88.70% 8 Missing and 6 partials :warning:
libs/common/src/services/api.service.ts 0.00% 11 Missing :warning:
...igrations/migrations/45-merge-environment-state.ts 68.75% 10 Missing :warning:
.../auth/components/environment-selector.component.ts 0.00% 9 Missing :warning:
apps/browser/src/background/runtime.background.ts 0.00% 7 Missing :warning:
...c/platform/services/browser-environment.service.ts 44.44% 5 Missing :warning:
...s/browser/src/popup/settings/settings.component.ts 0.00% 5 Missing :warning:
apps/cli/src/commands/config.command.ts 0.00% 5 Missing :warning:
... and 40 more
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #8040      +/-   ##
==========================================
- Coverage   26.35%   26.29%   -0.06%     
==========================================
  Files        2285     2286       +1     
  Lines       66918    66973      +55     
  Branches    12575    12571       -4     
==========================================
- Hits        17634    17613      -21     
- Misses      47911    47982      +71     
- Partials     1373     1378       +5

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Feb 22 '24 09:02 codecov[bot]

Logo Checkmarx One – Scan Summary & Details – 208e26b5-ab50-45e8-a253-e2917e879d59

New Issues

Severity Issue Source File / Package Checkmarx Insight
MEDIUM Unpinned Actions Full Length Commit SHA /version-bump.yml: 138 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /version-auto-bump.yml: 47 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /build-desktop.yml: 1254 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /build-desktop.yml: 285 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /build-desktop.yml: 1208 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /version-bump.yml: 131 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
LOW Client_DOM_Open_Redirect /apps/desktop/src/auth/accessibility-cookie.component.html: 18 Attack Vector
LOW Unprotected_Cookie /apps/web/src/app/auth/two-factor.component.ts: 132 Attack Vector
LOW Unsafe_Use_Of_Target_blank /apps/desktop/src/auth/accessibility-cookie.component.ts: 92 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 14 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 63 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 45 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 13 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 29 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 26 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 22 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 47 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 27 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 16 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 28 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 40 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 13 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 32 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 44 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 34 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 50 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 17 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 17 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 35 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 22 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 61 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 37 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 48 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 21 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 56 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 33 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 34 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 48 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 66 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 28 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 40 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 28 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 34 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 25 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 19 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 39 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 15 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 47 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 65 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 32 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 61 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 42 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 62 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 35 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 30 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 41 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 35 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 51 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 49 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 19 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 29 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 55 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 20 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 23 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 62 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 41 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 31 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 46 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 50 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 19 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 41 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 66 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 33 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 31 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 46 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 59 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 53 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 59 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 22 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 40 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 38 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 64 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 62 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 38 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 26 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 45 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 53 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 15 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 36 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 36 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 47 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 23 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 16 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 26 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 17 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 13 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 30 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 55 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 30 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 52 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 66 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 45 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 37 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 54 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 36 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 16 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 48 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 21 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 21 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 52

More results are available on AST platform

bitwarden-bot avatar Feb 22 '24 10:02 bitwarden-bot

I've sent this off to QA for testing before a final conflict resolve and a round of reviews.

Hinton avatar Mar 12 '24 11:03 Hinton