clients
clients copied to clipboard
AC-2161 update cipher collections org vault modal
- [ ] Bug fix
- [ X ] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other
Objective
When Org has Owners and Admins can manage all collections and items turned on
- Owner can open the
Edit Collectionsmodal and add/remove collections associated with the cipher
When Org has Owners and Admins can manage all collections and items turned off
- Owner can open the
Edit Collectionsmodal - Collections they have
readOnlyaccess to will be on the bottom - If the cipher does not have any
Can Editcollections associated with it, the Owner will be blocked from updating that ciphers collections. When trying to save in this instance they will get an error toast
Code changes
- vault.component - Added a sort for collections before opening the Modal. Update to show all collections instead of only
editableCollections$. Pass in flexible collections flag to modal - collections.component.ts (individual)- Do not allow check to complete on readOnly cipher row
- collections.component.ts (org) - use the
canEditAllCiphersboolean to assess what endpoint to hit - collections.component.ts (admin-console) - access if org canEditAnyCollection is turned on/off
- collections.component.html - Added disable to the checkbox of the readOnly cipher
Recording
https://github.com/bitwarden/clients/assets/8302660/4ae47547-08da-4054-bc41-0ec43748047b
Codecov Report
Attention: Patch coverage is 8.16327% with 45 lines in your changes are missing coverage. Please review.
Project coverage is 26.22%. Comparing base (
cd5dc09) to head (36f5c43).
:exclamation: Current head 36f5c43 differs from pull request most recent head a744ade. Consider uploading reports for the commit a744ade to get more accurate results
Additional details and impacted files
@@ Coverage Diff @@
## main #8027 +/- ##
==========================================
- Coverage 26.34% 26.22% -0.12%
==========================================
Files 2286 2278 -8
Lines 66938 66817 -121
Branches 12577 12571 -6
==========================================
- Hits 17635 17524 -111
+ Misses 47930 47925 -5
+ Partials 1373 1368 -5
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Checkmarx One – Scan Summary & Details – 56d484e0-54d3-4317-baed-29a8115e71b3