clients [PM-5725] New passkeys should always return 0 as counter value

[PM-5725] New passkeys should always return 0 as counter value

Open coroiu opened this issue 1 year ago • 2 comments

trafficstars

Type of change

- [ ] Bug fix
- [x] New feature development
- [x] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Remove incrementing counter for new passkeys. Will help us in the future with export/import, improving performance, etc.

Note: Older clients will still increment these new passkeys and "activate" the counter incrementing function. This is ok. Browser extensions are usually updated fairly quickly and so the amount of passkeys that this happens to should be limited.

Code changes

Only increment counter if stored value is larger than zero

Before you submit

Please add unit tests where it makes sense to do so (encouraged but not required)
If this change requires a documentation update - notify the documentation team
If this change has particular deployment requirements - notify the DevOps team
Ensure that all UI additions follow WCAG AA requirements

Feb 21 '24 09:02 coroiu

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (8f08ba3) 24.13% compared to head (a6e8a68) 24.13%. Report is 3 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #8024   +/-   ##
=======================================
  Coverage   24.13%   24.13%           
=======================================
  Files        2212     2212           
  Lines       65109    65111    +2     
  Branches    12326    12328    +2     
=======================================
+ Hits        15715    15717    +2     
  Misses      48072    48072           
  Partials     1322     1322

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.