[PM-5434] Create VaultBrowserStateService and migrate components from BrowserStateService

[LRNcardozoWDF]

trafficstars

Type of change

- [ ] Bug fix
- [ ] New feature development
- [X] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Migrate browserGroupingComponentState and browserVaultItemsComponentState to the State Provider framework in newly VaultBrowserStateService.

Code changes

• apps/browser/src/platform/services/browser-state.service.spec.ts: Migrated method tests removed.
• apps/browser/src/vault/services/vault-browser-state.service.ts: Created service to hold browserGroupingComponentState and browserVaultItemsComponentState .
• libs/common/src/platform/state/state-definitions.ts: Added state definition to store data on memory.

Before you submit

• Please add unit tests where it makes sense to do so (encouraged but not required)
• If this change requires a documentation update - notify the documentation team
• If this change has particular deployment requirements - notify the DevOps team
• Ensure that all UI additions follow WCAG AA requirements

[codecov[bot]]

Codecov Report

Attention: Patch coverage is 61.29032% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 26.92%. Comparing base (a201e9c) to head (a65dc56).

Files	Patch %	Lines
...t/popup/components/vault/vault-filter.component.ts	0.00%	6 Missing :warning:
apps/browser/src/popup/app.component.ts	0.00%	2 Missing :warning:
apps/browser/src/popup/services/services.module.ts	0.00%	2 Missing :warning:
...lt/popup/components/vault/vault-items.component.ts	0.00%	2 Missing :warning:

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #8017      +/-   ##
==========================================
+ Coverage   26.89%   26.92%   +0.02%     
==========================================
  Files        2311     2312       +1     
  Lines       67465    67480      +15     
  Branches    12642    12641       -1     
==========================================
+ Hits        18148    18169      +21     
+ Misses      47924    47916       -8     
- Partials     1393     1395       +2     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

[bitwarden-bot]

Checkmarx One – Scan Summary & Details – 6b6e455c-fdec-4f28-81be-709aee734293

New Issues

Severity	Issue	Source File / Package	Checkmarx Insight
	Client_DOM_XSS	/apps/web/src/app/auth/settings/two-factor-verify.component.html: 3	Attack Vector
	Client_DOM_XSS	/bitwarden_license/bit-web/src/app/admin-console/providers/settings/account.component.html: 27	Attack Vector
	Client_DOM_XSS	/bitwarden_license/bit-web/src/app/admin-console/providers/settings/account.component.html: 27	Attack Vector
	Client_Potential_XSS	/apps/desktop/src/app/components/avatar.component.ts: 45	Attack Vector
	Client_Potential_XSS	/libs/components/src/avatar/avatar.component.ts: 48	Attack Vector
	Client_Potential_XSS	/apps/desktop/src/app/components/avatar.component.ts: 45	Attack Vector
	Use_Of_Hardcoded_Password	/libs/common/src/tools/send/services/send.service.ts: 26	Attack Vector
	Use_Of_Hardcoded_Password	/libs/common/src/tools/send/services/send.service.ts: 25	Attack Vector
	Use_Of_Hardcoded_Password	/apps/cli/src/tools/export.command.ts: 119	Attack Vector
	Use_Of_Hardcoded_Password	/apps/cli/src/tools/export.command.ts: 117	Attack Vector
	Use_Of_Hardcoded_Password	/apps/cli/src/tools/export.command.ts: 118	Attack Vector
	Use_Of_Hardcoded_Password	/apps/cli/src/tools/export.command.ts: 119	Attack Vector
	Use_Of_Hardcoded_Password	/apps/cli/src/tools/export.command.ts: 118	Attack Vector
	Use_Of_Hardcoded_Password	/apps/cli/src/tools/export.command.ts: 117	Attack Vector
	Use_Of_Hardcoded_Password	/apps/cli/src/auth/commands/login.command.ts: 289	Attack Vector
	Use_Of_Hardcoded_Password	/apps/cli/src/auth/commands/login.command.ts: 147	Attack Vector
	Use_Of_Hardcoded_Password	/apps/cli/src/auth/commands/login.command.ts: 147	Attack Vector
	Use_Of_Hardcoded_Password	/apps/cli/src/auth/commands/login.command.ts: 148	Attack Vector
	Use_Of_Hardcoded_Password	/apps/cli/src/auth/commands/login.command.ts: 148	Attack Vector
	Use_Of_Hardcoded_Password	/apps/cli/src/auth/commands/login.command.ts: 641	Attack Vector
	Use_Of_Hardcoded_Password	/apps/cli/src/auth/commands/login.command.ts: 657	Attack Vector
	Use_Of_Hardcoded_Password	/apps/cli/src/auth/commands/login.command.ts: 666	Attack Vector
	Use_Of_Hardcoded_Password	/apps/cli/src/auth/commands/login.command.ts: 146	Attack Vector
	Use_Of_Hardcoded_Password	/apps/cli/src/auth/commands/login.command.ts: 667	Attack Vector
	Use_Of_Hardcoded_Password	/apps/cli/src/auth/commands/login.command.ts: 669	Attack Vector
	Use_Of_Hardcoded_Password	/apps/cli/src/auth/commands/login.command.ts: 125	Attack Vector
	Use_Of_Hardcoded_Password	/apps/cli/src/auth/commands/login.command.ts: 146	Attack Vector
	Use_Of_Hardcoded_Password	/apps/cli/src/auth/commands/login.command.ts: 148	Attack Vector
	Use_Of_Hardcoded_Password	/apps/cli/src/auth/commands/login.command.ts: 147	Attack Vector
	Use_Of_Hardcoded_Password	/apps/cli/src/auth/commands/login.command.ts: 643	Attack Vector
	Use_Of_Hardcoded_Password	/apps/cli/src/auth/commands/login.command.ts: 147	Attack Vector
	Use_Of_Hardcoded_Password	/apps/cli/src/auth/commands/login.command.ts: 146	Attack Vector
	Use_Of_Hardcoded_Password	/apps/cli/src/auth/commands/login.command.ts: 123	Attack Vector
	Use_Of_Hardcoded_Password	/apps/cli/src/auth/commands/login.command.ts: 146	Attack Vector
	Use_Of_Hardcoded_Password	/apps/cli/src/auth/commands/login.command.ts: 147	Attack Vector
	Use_Of_Hardcoded_Password	/apps/cli/src/auth/commands/login.command.ts: 100	Attack Vector
	Use_Of_Hardcoded_Password	/apps/cli/src/auth/commands/login.command.ts: 148	Attack Vector
	Use_Of_Hardcoded_Password	/apps/cli/src/auth/commands/login.command.ts: 287	Attack Vector
	Use_Of_Hardcoded_Password	/apps/cli/src/auth/commands/login.command.ts: 124	Attack Vector
	Use_Of_Hardcoded_Password	/apps/cli/src/auth/commands/login.command.ts: 642	Attack Vector
	Use_Of_Hardcoded_Password	/apps/cli/src/auth/commands/login.command.ts: 288	Attack Vector
	Use_Of_Hardcoded_Password	/apps/cli/src/auth/commands/login.command.ts: 148	Attack Vector
	Use_Of_Hardcoded_Password	/apps/cli/src/auth/commands/login.command.ts: 146	Attack Vector
	Use_Of_Hardcoded_Password	/apps/cli/src/auth/commands/login.command.ts: 100	Attack Vector
	Use_Of_Hardcoded_Password	/libs/auth/src/angular/user-verification/user-verification-form-input.component.ts: 71	Attack Vector
	Use_Of_Hardcoded_Password	/libs/auth/src/angular/user-verification/user-verification-form-input.component.ts: 71	Attack Vector
	Use_Of_Hardcoded_Password	/libs/auth/src/angular/user-verification/user-verification-form-input.component.ts: 71	Attack Vector
	Use_Of_Hardcoded_Password	/libs/auth/src/angular/user-verification/user-verification-form-input.component.ts: 71	Attack Vector
	Use_Of_Hardcoded_Password	/apps/cli/src/auth/commands/login.command.ts: 456	Attack Vector
	Use_Of_Hardcoded_Password	/apps/cli/src/auth/commands/login.command.ts: 513	Attack Vector
	Use_Of_Hardcoded_Password	/apps/cli/src/auth/commands/login.command.ts: 538	Attack Vector
	Use_Of_Hardcoded_Password	/apps/cli/src/auth/commands/login.command.ts: 418	Attack Vector
	Use_Of_Hardcoded_Password	/apps/cli/src/auth/commands/login.command.ts: 456	Attack Vector
	Use_Of_Hardcoded_Password	/apps/cli/src/auth/commands/login.command.ts: 513	Attack Vector
	Use_Of_Hardcoded_Password	/apps/cli/src/auth/commands/login.command.ts: 513	Attack Vector
	Use_Of_Hardcoded_Password	/apps/cli/src/auth/commands/login.command.ts: 555	Attack Vector
	Use_Of_Hardcoded_Password	/apps/cli/src/auth/commands/login.command.ts: 513	Attack Vector
	Use_Of_Hardcoded_Password	/apps/cli/src/auth/commands/login.command.ts: 555	Attack Vector
	Use_Of_Hardcoded_Password	/apps/cli/src/auth/commands/login.command.ts: 538	Attack Vector
	Use_Of_Hardcoded_Password	/apps/cli/src/auth/commands/login.command.ts: 538	Attack Vector
	Use_Of_Hardcoded_Password	/apps/cli/src/auth/commands/login.command.ts: 555	Attack Vector
	Use_Of_Hardcoded_Password	/apps/cli/src/auth/commands/login.command.ts: 555	Attack Vector
	Use_Of_Hardcoded_Password	/apps/cli/src/auth/commands/login.command.ts: 418	Attack Vector
	Use_Of_Hardcoded_Password	/apps/cli/src/auth/commands/login.command.ts: 538	Attack Vector
	Use_Of_Hardcoded_Password	/apps/cli/src/auth/commands/login.command.ts: 456	Attack Vector
	Use_Of_Hardcoded_Password	/apps/cli/src/auth/commands/login.command.ts: 555	Attack Vector
	Use_Of_Hardcoded_Password	/apps/cli/src/auth/commands/login.command.ts: 513	Attack Vector
	Use_Of_Hardcoded_Password	/apps/cli/src/auth/commands/login.command.ts: 513	Attack Vector
	Use_Of_Hardcoded_Password	/apps/cli/src/auth/commands/login.command.ts: 513	Attack Vector
	Use_Of_Hardcoded_Password	/apps/cli/src/auth/commands/login.command.ts: 456	Attack Vector
	Use_Of_Hardcoded_Password	/apps/cli/src/auth/commands/login.command.ts: 513	Attack Vector
	Use_Of_Hardcoded_Password	/apps/cli/src/auth/commands/login.command.ts: 555	Attack Vector
	Use_Of_Hardcoded_Password	/apps/cli/src/auth/commands/login.command.ts: 418	Attack Vector
	Use_Of_Hardcoded_Password	/apps/cli/src/auth/commands/login.command.ts: 538	Attack Vector
	Use_Of_Hardcoded_Password	/apps/cli/src/auth/commands/login.command.ts: 513	Attack Vector
	Use_Of_Hardcoded_Password	/apps/cli/src/auth/commands/login.command.ts: 513	Attack Vector
	Use_Of_Hardcoded_Password	/apps/cli/src/auth/commands/login.command.ts: 456	Attack Vector
	Use_Of_Hardcoded_Password	/apps/cli/src/auth/commands/login.command.ts: 513	Attack Vector
	Use_Of_Hardcoded_Password	/apps/cli/src/auth/commands/login.command.ts: 456	Attack Vector
	Use_Of_Hardcoded_Password	/apps/cli/src/auth/commands/login.command.ts: 538	Attack Vector
	Use_Of_Hardcoded_Password	/apps/cli/src/auth/commands/login.command.ts: 555	Attack Vector
	Use_Of_Hardcoded_Password	/apps/cli/src/auth/commands/login.command.ts: 418	Attack Vector
	Use_Of_Hardcoded_Password	/apps/cli/src/auth/commands/login.command.ts: 418	Attack Vector
	Use_Of_Hardcoded_Password	/apps/cli/src/auth/commands/login.command.ts: 513	Attack Vector
	Use_Of_Hardcoded_Password	/apps/cli/src/auth/commands/login.command.ts: 418	Attack Vector
	Use_Of_Hardcoded_Password	/apps/cli/src/auth/commands/login.command.ts: 538	Attack Vector
	Use_Of_Hardcoded_Password	/apps/cli/src/auth/commands/login.command.ts: 513	Attack Vector
	Use_Of_Hardcoded_Password	/apps/cli/src/auth/commands/login.command.ts: 456	Attack Vector
	Use_Of_Hardcoded_Password	/apps/cli/src/auth/commands/login.command.ts: 513	Attack Vector
	Use_Of_Hardcoded_Password	/apps/cli/src/auth/commands/login.command.ts: 513	Attack Vector
	Use_Of_Hardcoded_Password	/apps/cli/src/auth/commands/login.command.ts: 418	Attack Vector
	Use_Of_Hardcoded_Password	/apps/cli/src/auth/commands/login.command.ts: 555	Attack Vector
	Use_Of_Hardcoded_Password	/apps/cli/src/auth/commands/login.command.ts: 513	Attack Vector
	Use_Of_Hardcoded_Password	/apps/cli/src/auth/commands/login.command.ts: 418	Attack Vector
	Use_Of_Hardcoded_Password	/apps/cli/src/auth/commands/login.command.ts: 538	Attack Vector
	Use_Of_Hardcoded_Password	/apps/cli/src/auth/commands/login.command.ts: 456	Attack Vector
	Use_Of_Hardcoded_Password	/libs/importer/src/importers/protonpass/protonpass-json-importer.ts: 44	Attack Vector
	Use_Of_Hardcoded_Password	/libs/common/src/vault/services/cipher.service.ts: 1077	Attack Vector
	Use_Of_Hardcoded_Password	/apps/browser/src/autofill/content/notification-bar.ts: 551	Attack Vector
	Use_Of_Hardcoded_Password	/apps/browser/src/autofill/content/notification-bar.ts: 557	Attack Vector
	Use_Of_Hardcoded_Password	/apps/browser/src/autofill/content/notification-bar.ts: 557	Attack Vector
	Use_Of_Hardcoded_Password	/apps/cli/src/auth/commands/login.command.ts: 507	Attack Vector
	Use_Of_Hardcoded_Password	/apps/cli/src/auth/commands/login.command.ts: 499	Attack Vector
	Use_Of_Hardcoded_Password	/apps/cli/src/auth/commands/login.command.ts: 496	Attack Vector
	Use_Of_Hardcoded_Password	/apps/cli/src/auth/commands/login.command.ts: 496	Attack Vector
	Use_Of_Hardcoded_Password	/apps/cli/src/auth/commands/login.command.ts: 500	Attack Vector
	Use_Of_Hardcoded_Password	/libs/common/src/platform/models/domain/enc-string.ts: 56	Attack Vector
	Use_Of_Hardcoded_Password	/apps/cli/src/utils.ts: 239	Attack Vector
	Use_Of_Hardcoded_Password

More results are available on AST platform