clients [PM-6147]Using reactive methods on SendAddEditComponent load

[PM-6147]Using reactive methods on SendAddEditComponent load

Open aj-rosado opened this issue 1 year ago • 2 comments

trafficstars

Type of change

- [ ] Bug fix
- [ ] New feature development
- [X] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Use the reactive method from SendService instead of the current Promise call

Code changes

libs/send/add-edit.component.ts: Swapped the existing get method call with the reactive method returning the Send data

Before you submit

Please add unit tests where it makes sense to do so (encouraged but not required)
If this change requires a documentation update - notify the documentation team
If this change has particular deployment requirements - notify the DevOps team
Ensure that all UI additions follow WCAG AA requirements

Feb 20 '24 10:02 aj-rosado

Codecov Report

Attention: Patch coverage is 0% with 23 lines in your changes are missing coverage. Please review.

Project coverage is 25.34%. Comparing base (2d49a79) to head (fce84d2).

Files	Patch %	Lines
libs/angular/src/tools/send/add-edit.component.ts	0.00%	23 Missing :warning:

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #8013      +/-   ##
==========================================
- Coverage   25.34%   25.34%   -0.01%     
==========================================
  Files        2259     2259              
  Lines       65983    65991       +8     
  Branches    12414    12418       +4     
==========================================
  Hits        16724    16724              
- Misses      47915    47923       +8     
  Partials     1344     1344

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.