clients icon indicating copy to clipboard operation
clients copied to clipboard

[PM-5009] migrate billing component

Open vinith-kovan opened this issue 1 year ago • 2 comments
trafficstars

Type of change

- [ ] Bug fix
- [ ] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [x] Other

Objective

Migrating billing component css to Tailwind css

Code changes

billing.component.html

Screenshots

After Migration image

Before Migration image

vinith-kovan avatar Feb 20 '24 04:02 vinith-kovan

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (d2cdc6f) 24.13% compared to head (d32a157) 24.13%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8011   +/-   ##
=======================================
  Coverage   24.13%   24.13%           
=======================================
  Files        2212     2212           
  Lines       65109    65109           
  Branches    12326    12326           
=======================================
  Hits        15715    15715           
  Misses      48072    48072           
  Partials     1322     1322           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Feb 20 '24 04:02 codecov[bot]

Logo Checkmarx One – Scan Summary & Details48d7c4d7-bfa7-4352-9a13-fdea177dfda5

Fixed Issues

Severity Issue Source File / Package
MEDIUM Client_Privacy_Violation /apps/web/src/app/billing/accounts/trial-initiation/billing.component.html: 41
MEDIUM Client_Privacy_Violation /apps/web/src/app/billing/accounts/trial-initiation/billing.component.html: 41
MEDIUM Client_Privacy_Violation /apps/web/src/app/billing/accounts/trial-initiation/billing.component.html: 41
MEDIUM Client_Privacy_Violation /apps/web/src/app/billing/accounts/trial-initiation/billing.component.html: 41
MEDIUM Client_Privacy_Violation /apps/web/src/app/billing/accounts/trial-initiation/billing.component.html: 19
MEDIUM Client_Privacy_Violation /apps/web/src/app/billing/accounts/trial-initiation/billing.component.html: 19
MEDIUM Client_Privacy_Violation /apps/web/src/app/billing/accounts/trial-initiation/billing.component.html: 19
MEDIUM Client_Privacy_Violation /apps/web/src/app/billing/accounts/trial-initiation/billing.component.html: 19

bitwarden-bot avatar Feb 20 '24 05:02 bitwarden-bot

@amorask-bitwarden, while resolving conflicts, it seems that billing-component.html got deleted so we don't need this PR.

vinith-kovan avatar May 21 '24 12:05 vinith-kovan

@amorask-bitwarden, while resolving conflicts, it seems that billing-component.html got deleted so we don't need this PR.

@vinith-kovan Yeah we can close this, thank you for checking.

amorask-bitwarden avatar Jun 20 '24 14:06 amorask-bitwarden

Closing this PR as it's no longer needed. Thank you for your work on it, @vinith-kovan!

cturnbull-bitwarden avatar Jun 21 '24 17:06 cturnbull-bitwarden