clients icon indicating copy to clipboard operation
clients copied to clipboard

[AC-2244] Fix submitting member invite form

Open eliykat opened this issue 1 year ago • 2 comments
trafficstars

Type of change

- [x] Bug fix
- [ ] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

As described in #7252, the member dialog does not submit until you intentionally click/tab off the email input field to blur it. EDIT: fixes #7156 (tracked as PM-5200)

This is caused by using updateOn: "blur" to delay validator behaviour, however our component library already takes care of this, so it is unnecessary. We can simply remove it.

I've also renamed the validator to be clearer and more concise.

Code changes

  • file.ext: Description of what was changed and why

Screenshots

Before you submit

  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team
  • Ensure that all UI additions follow WCAG AA requirements

eliykat avatar Feb 20 '24 00:02 eliykat

Codecov Report

Attention: Patch coverage is 50.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 25.16%. Comparing base (ed2bd7c) to head (fc91127).

Files Patch % Lines
...omponents/member-dialog/member-dialog.component.ts 0.00% 1 Missing :warning:
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8009   +/-   ##
=======================================
  Coverage   25.16%   25.16%           
=======================================
  Files        2250     2250           
  Lines       65827    65827           
  Branches    12412    12412           
=======================================
  Hits        16564    16564           
  Misses      47921    47921           
  Partials     1342     1342           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Feb 20 '24 00:02 codecov[bot]

Logo Checkmarx One – Scan Summary & Detailse0e6377b-207f-4384-a1ff-58ef0e311803

No New Or Fixed Issues Found

bitwarden-bot avatar Feb 20 '24 01:02 bitwarden-bot