clients
clients copied to clipboard
[PM-5743] Implement eslint rule for usage of window object in background script
trafficstars
WIP
Type of change
- [ ] Bug fix
- [ ] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other
Objective
Code changes
- file.ext: Description of what was changed and why
Screenshots
Before you submit
- Please add unit tests where it makes sense to do so (encouraged but not required)
- If this change requires a documentation update - notify the documentation team
- If this change has particular deployment requirements - notify the DevOps team
- Ensure that all UI additions follow WCAG AA requirements
Checkmarx One – Scan Summary & Details – eb864868-b381-47f6-a847-9a4f115cd434
Fixed Issues
| Severity | Issue | Source File / Package |
|---|---|---|
![]() |
Client_Privacy_Violation | /apps/web/src/app/billing/shared/add-credit.component.ts: 146 |
![]() |
Client_Privacy_Violation | /apps/web/src/app/billing/shared/add-credit.component.ts: 80 |
![]() |
Client_Privacy_Violation | /apps/web/src/app/billing/shared/add-credit.component.ts: 30 |
![]() |
Client_Privacy_Violation | /apps/web/src/app/billing/shared/add-credit.component.ts: 70 |
![]() |
Client_Privacy_Violation | /apps/web/src/app/billing/shared/add-credit.component.ts: 135 |
![]() |
Client_Privacy_Violation | /bitwarden_license/bit-web/src/app/auth/sso/sso.component.ts: 161 |
![]() |
Client_DOM_Open_Redirect | /apps/desktop/src/auth/login/login-via-auth-request.component.ts: 60 |
![]() |
Client_DOM_Open_Redirect | /apps/browser/src/auth/popup/login-via-auth-request.component.ts: 52 |
![]() |
Client_DOM_Open_Redirect | /apps/browser/src/auth/popup/login-via-auth-request.component.ts: 52 |
![]() |
Client_DOM_Open_Redirect | /apps/desktop/src/auth/login/login-via-auth-request.component.ts: 60 |
Codecov Report
Attention: Patch coverage is 33.33333% with 20 lines in your changes are missing coverage. Please review.
Project coverage is 26.75%. Comparing base (
3a83078) to head (a938e95).
Additional details and impacted files
@@ Coverage Diff @@
## main #7849 +/- ##
=======================================
Coverage 26.75% 26.75%
=======================================
Files 2306 2306
Lines 67370 67370
Branches 12625 12625
=======================================
Hits 18027 18027
Misses 47955 47955
Partials 1388 1388
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

