clients icon indicating copy to clipboard operation
clients copied to clipboard

[PM-4373] Update argon2 to 0.31.1 to fix linux/arm64 install

Open jrcichra opened this issue 2 years ago • 5 comments
trafficstars

Type of change

- [ x] Bug fix
- [ ] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Fixes https://github.com/bitwarden/clients/issues/6458

When installing @bitwarden/cli on arm64 the prebuilt binary is not available:

 #24 339.6 npm ERR! node-pre-gyp info using [email protected]
#24 339.6 npm ERR! node-pre-gyp info using [email protected] | linux | arm64
#24 339.6 npm ERR! node-pre-gyp info check checked for "/usr/local/lib/node_modules/@bitwarden/cli/node_modules/argon2/lib/binding/napi-v3/argon2.node" (not found)
#24 339.6 npm ERR! node-pre-gyp http GET https://github.com/ranisalt/node-argon2/releases/download/v0.31.0/argon2-v0.31.0-napi-v3-linux-arm64-glibc.tar.gz
#24 339.6 npm ERR! node-pre-gyp ERR! install response status 404 Not Found on https://github.com/ranisalt/node-argon2/releases/download/v0.31.0/argon2-v0.31.0-napi-v3-linux-arm64-glibc.tar.gz 
#24 339.6 npm ERR! node-pre-gyp WARN Pre-built binaries not installable for [email protected] and [email protected] (node-v108 ABI, glibc) (falling back to source compile with node-gyp) 
#24 339.6 npm ERR! node-pre-gyp WARN Hit error response status 404 Not Found on https://github.com/ranisalt/node-argon2/releases/download/v0.31.0/argon2-v0.31.0-napi-v3-linux-arm64-glibc.tar.gz 
#24 339.6 npm ERR! gyp info it worked if it ends with ok

This was addressed in the next patch release, 0.31.1: https://github.com/ranisalt/node-argon2/releases/tag/v0.31.1

Upgrading from 0.31.0 to 0.31.1 in bitwarden/cli will resolve this build issue.

Code changes

  • package.json: Upgraded node-argon2 from 0.31.0 to 0.31.1
    • package-lock.json: Upgraded node-argon2 from 0.31.0 to 0.31.1

Screenshots

Before you submit

  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team
  • Ensure that all UI additions follow WCAG AA requirements

jrcichra avatar Oct 17 '23 12:10 jrcichra

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Oct 17 '23 12:10 CLAassistant

Thank you for your contribution! We've added this to our internal Community PR board for review. ID: PM-4373

bitwarden-bot avatar Oct 17 '23 12:10 bitwarden-bot

Logo Checkmarx One – Scan Summary & Detailscd6f2e70-59f4-421a-bb08-3cf70c5720f5

No New Or Fixed Issues Found

bitwarden-bot avatar Oct 17 '23 14:10 bitwarden-bot

I've had success keeping my bitwarden cli pinned to @bitwarden/[email protected] until a fix is merged.

jrcichra avatar Feb 22 '24 20:02 jrcichra

I've had success keeping my bitwarden cli pinned to @bitwarden/[email protected] until a fix is merged.

Thank you, I can confirm that v2023.8.2 seems to be the last working version on arm64 until your PR is merged.

aleksandarristic avatar Feb 26 '24 10:02 aleksandarristic

Thank you for your contribution, in the course of dependency updates, it appears that https://github.com/bitwarden/clients/pull/8073 should resolve this issue. Closing this PR for now. If your build issues are not fixed, we'll need to investigate something further than lib version.

MGibson1 avatar Jun 25 '24 15:06 MGibson1