clients icon indicating copy to clipboard operation
clients copied to clipboard

[PS-1502] Handle already verified email when resending verification email

Open schang1146 opened this issue 3 years ago • 1 comments

Type of change

- [x] Bug fix
- [ ] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Fix for #2800 where clicking the "Send Email" button in the warning box pops up an error telling the user that the email is already verified.

Code changes

  • apps/web/src/app/settings/verify-email.component.ts Added some logic to check if an email is already verified or not when a user clicks on the "Send Email" button. Added an EventEmitter to the verify-email component so that it can let its parent know that the email's already verified and that it can close the warning box. Added code to pop-up a Toast briefly letting the user know that their email is verified.

  • apps/web/src/app/vault/vault.component.html Added the EventEmitter to the template to call a new function updateVerifyEmail.

  • apps/web/src/app/vault/vault.component.ts Added new function updateVerifyEmail to update this.showVerifyEmail variable.

Feel free to let me know if naming could be better 😅

Screenshots

I'm getting better at this but the quality is poop.

https://user-images.githubusercontent.com/20074034/190708338-59206a2e-9f3b-4bd8-b601-32ea758a0e72.mp4

Before you submit

  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

schang1146 avatar Sep 16 '22 18:09 schang1146

Thank you for your contribution! We've added this to our internal Community PR board for review. ID: PS-1502

bitwarden-bot avatar Sep 16 '22 18:09 bitwarden-bot

Merging this into a feature branch to let QA test it first.

Thanks for the contribution @schang1146.

Hinton avatar Oct 28 '22 14:10 Hinton

hey is this issue still open?

nikhilagastya avatar May 10 '23 06:05 nikhilagastya

I think the issue's closed. Haven't heard further feedback that it's broken.

#2810 wasn't closed because the PR was linked after it was merged.

schang1146 avatar May 10 '23 06:05 schang1146

@schang1146 Thanks again for the contribution and for raising this. @nikhilagastya I'm going to close #2810 but if the issue persists, please comment on there and we can re-open if needed

djsmith85 avatar May 10 '23 09:05 djsmith85

Sure @djsmith85 ,thanks alot !

nikhilagastya avatar May 10 '23 16:05 nikhilagastya