clients icon indicating copy to clipboard operation
clients copied to clipboard

The "Import Data", "Premium Membership", "Subscription" and "Edit User" pages contain strings that cannot be translated

Open olavinto opened this issue 4 years ago • 13 comments

Describe the Bug

It seems that the "Choose File" button text and its "No file chosen" description can't be translated at Crowdin (at least I could not find them there). Both Finnish and English screenshots are attached.

These are located under "Tools" > "Import Data" > "2. Select the import file".

The membership and subscription status message is also not translatable it seems.

Located under "Settings" > "Premium Membership" and Organization "Settings" > "Subscription".

One addition to this list: "Organization Settings > Manage > People" page "Edit User" screen. The headers for custom permissions do not seem to be available for translation at Crowdin.

Screenshots

Tools > Import Data: bitwarden_import_en bitwarden_import_fi

Settings > Premium Membership: english finnish

Organization Settings > Subscription: english_org

Organization Settings > Manage > People > Edit User: en fi

Environment

  • Build Version: [2.21.1]

olavinto avatar Jul 04 '21 08:07 olavinto

I added other untranslatable strings here and updated the issue with new screenshots and descriptions. I thought that it's better than posting a new issue since this is still open.

The "Annually" strings are also not translated here although I'm not sure if this is just because the Finnish translation has not been updated after the string was translated. An "Annually" string has been translated at Crowdin but because there isn't any contextual information there, I'm not sure if the translated strings is actually the one shown on these pages.

olavinto avatar Aug 07 '21 10:08 olavinto

It seems that plan names are also not translatable by the way. Meaning "Teams" and "Enterprise". These could very well be translated, I think?

olavinto avatar Aug 07 '21 12:08 olavinto

It actually seems that the form elements on the data import page get the translations from the browser based on its language instead of the Bitwarden translation. I mainly use English myself (I'm a native Finnish speaker but for tech related stuff English just tends to sound better) and Finnish mostly for testing so that is why this stood out to me previously. Many users will not notice the problem if their browser is in the same language as the site. This is still problematic because there are cases where you might be forced to use English as your system and application language but might still want to use websites in Finnish (this is actually quite common at least in Finland: large, international businesses do not bother to setup systems in Finnish even when they have local, native IT support).

olavinto avatar Oct 28 '21 10:10 olavinto

I could work on that

lidianycs avatar Nov 03 '21 03:11 lidianycs

One addition to this list: "Organization Settings > Manage > People" page "Edit User" screen. The headers for custom permissions do not seem to be available for translation at Crowdin. Screenshots are in the op.

olavinto avatar Nov 11 '21 21:11 olavinto

Hi @olavinto, We're cleaning up our repositories in preparation for a major reorganization. Issues from last year will be marked as stale and closed after two weeks. If you still need help, comment to let us know and we'll look into it. Thanks!

bitwarden-bot avatar Apr 12 '22 19:04 bitwarden-bot

I now had the time to check these and they are all still valid.

olavinto avatar May 07 '22 07:05 olavinto

Hello, newbie here and very interested in tackling this issue if allowed!

adamkaplan0 avatar Jun 10 '22 17:06 adamkaplan0

Is anyone actively working on this? Planning on working on it if not.

Edit: I'm seeing the issue still there for the above-mentioned locations.

schang1146 avatar Sep 11 '22 01:09 schang1146

Is anyone actively working on this? Planning on working on it if not.

Edit: I'm seeing the issue still there for the above-mentioned locations.

Not me, I'm just the reporter. My coding experience is limited to HTML and CSS and even that was mostly years ago. Hopefully someone can fix these!

olavinto avatar Sep 11 '22 08:09 olavinto

Cool, I hope it's good with others. I am making progress on this, and I'll keep the thread updated :)

schang1146 avatar Sep 11 '22 08:09 schang1146

A bit blocked on using Crowdin/getting translations and the "Status" options.

Crowdin stuff:

I'm not too familiar with Crowdin and the workflow to get translations in for it. I've updated the English messages.json (src/locales/en) and the Finnish messages.json (src/locales/fi) to test with.

I did find the Bitwarden - Web project in Crowdin. Do we just update the messages.json for English and the others get auto-updated when translations are submitted?

Status stuff:

Also, looks like the way translations are handled, we'd need an entry for all the different options Status can have:

  • active
  • canceled
  • unpaid
  • incomplete_expired
  • trialing

Would we want to make an entry for each of those in the messages.json file?

I'm worried if a new status is ever created (or if I missed any) and it's not populated on the messages.json file, it'll just show up blank.

Progress:

Tools > Import Data (English) image image

Tools > Import Data (Finnish) image image

Organization Settings > Manage > People > Edit User (English) image

Organization Settings > Manage > People > Edit User (Finnish) image

schang1146 avatar Sep 11 '22 21:09 schang1146

@olavinto thanks for pointing this out, and @schang1146 thank you for working on this. Please create a PR once ready, and the team will be happy to review it. We appreciate your help!

dbosompem avatar Sep 12 '22 12:09 dbosompem