clients
clients copied to clipboard
[PM-22469] [PM-22468] fix: unhandled access token decryption failure case
đī¸ Tracking
https://github.com/bitwarden/clients/issues/15110
đ Objective
This PR is a fix for the case where the Unknown Error repeatedly occurs on Windows machines. This appears to be a case where outdated or invalid Access Tokens are still being attempted to be accessed once someone logs in on another client on the same machine using the master password. Once invalidated by the login elsewhere, the client will always fail decryption on devices that are set up to use Windows Hello authentication and will repeatedly show the unknown error popups even upon restarts.
đ¸ Screenshots
None
â° Reminders before review
- Contributor guidelines followed
- All formatters and local linters executed and passed
- Written new unit and / or integration tests where applicable
- Protected functional changes with optionality (feature flags)
- Used internationalization (i18n) for all UI strings
- CI builds passed
- Communicated to DevOps any deployment requirements
- Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team
đĻŽ Reviewer guidelines
- đ (
:+1:) or similar for great changes - đ (
:memo:) or âšī¸ (:information_source:) for notes or general info - â (
:question:) for questions - đ¤ (
:thinking:) or đ (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - đ¨ (
:art:) for suggestions / improvements - â (
:x:) or â ī¸ (:warning:) for more significant problems or concerns needing attention - đą (
:seedling:) or âģī¸ (:recycle:) for future improvements or indications of technical debt - â (
:pick:) for minor or nitpick changes
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.
Thank you for your contribution! We've added this to our internal Community PR board for review. ID: PM-22469 Link: https://bitwarden.atlassian.net/browse/PM-22469
Details on our contribution process can be found here: https://contributing.bitwarden.com/contributing/pull-requests/community-pr-process.
@zenocross , thank you very much for this submission. Can you please sign the CLA and update the libs/common/src/auth/services/token.service.spec.ts file to include this new error scenario?
@zenocross, I'd like to move forward with these changes whenever you get a chance to complete: https://github.com/bitwarden/clients/pull/15111#issuecomment-3001711882
@zenocross we do believe this is a valid fix for the problem you're experiencing, and we appreciate the time you took to submit it. However, we cannot proceed without you first signing the CLA. If you are unable to do so, or believe that you already have done so and this is reporting inaccurately, please let us know so that we can proceed accordingly. If we don't hear back, we will need to close this PR and proceed with internal investigation into a fix at a later time.
Thank you again for your contribution!