clients icon indicating copy to clipboard operation
clients copied to clipboard

[PM-4347] Upgrade angular to 17

Open Hinton opened this issue 1 year ago â€ĸ 2 comments

đŸŽŸī¸ Tracking

https://bitwarden.atlassian.net/browse/PM-4347

📔 Objective

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

đŸĻŽ Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or â„šī¸ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or âš ī¸ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or â™ģī¸ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Hinton avatar Sep 13 '24 15:09 Hinton

Logo Checkmarx One – Scan Summary & Details – 87cdd0da-1081-4229-9ef9-e7df4e6f84c8

No New Or Fixed Issues Found

github-actions[bot] avatar Sep 13 '24 15:09 github-actions[bot]

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 33.53%. Comparing base (c96b4f4) to head (1b2f846). Report is 1 commits behind head on main.

:white_check_mark: All tests successful. No failed tests found.

Files with missing lines Patch % Lines
apps/web/src/polyfills.ts 0.00% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11031      +/-   ##
==========================================
+ Coverage   33.51%   33.53%   +0.02%     
==========================================
  Files        2815     2815              
  Lines       87564    87646      +82     
  Branches    16695    16694       -1     
==========================================
+ Hits        29344    29395      +51     
- Misses      55911    55942      +31     
  Partials     2309     2309              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Sep 13 '24 15:09 codecov[bot]