clients icon indicating copy to clipboard operation
clients copied to clipboard

[PM-11329] [chore] Add "otp" TotpFieldNames array in autofill-constants.ts

Open mulderje opened this issue 1 year ago â€ĸ 3 comments
trafficstars

Add "otp" TotpFieldNames array in autofill-constants.ts. Noticed on https://id.fedoraproject.org/login/

đŸŽŸī¸ Tracking

N/A

📔 Objective

Add "otp" TotpFieldNames array in autofill-constants.ts. Noticed on https://id.fedoraproject.org/login/

As an aside, has a custom "linked" field been considered here like with passwords? I noticed at least one request on the forum, but couldn't find much here with a search.

📸 Screenshots

N/A

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

đŸĻŽ Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or â„šī¸ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or âš ī¸ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or â™ģī¸ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

mulderje avatar Aug 25 '24 15:08 mulderje

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Aug 25 '24 15:08 CLAassistant

Thank you for your contribution! We've added this to our internal Community PR board for review. ID: PM-11329

bitwarden-bot avatar Aug 25 '24 15:08 bitwarden-bot

Logo Checkmarx One – Scan Summary & Details – 12bce8e0-f5f6-483d-9067-3cf7fe300ef4

New Issues

Severity Issue Source File / Package Checkmarx Insight
MEDIUM Unpinned Actions Full Length Commit SHA /build-cli.yml: 402 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...

Fixed Issues

Severity Issue Source File / Package
MEDIUM Unpinned Actions Full Length Commit SHA /build-cli.yml: 405
LOW Client_DOM_Open_Redirect /apps/web/src/connectors/common.ts: 2
LOW Client_DOM_Open_Redirect /apps/web/src/connectors/common.ts: 2
LOW Client_DOM_Open_Redirect /apps/web/src/connectors/common.ts: 2
LOW Client_Use_Of_Iframe_Without_Sandbox /apps/browser/src/autofill/overlay/notifications/content/overlay-notifications-content.service.ts: 165

github-actions[bot] avatar Aug 28 '24 15:08 github-actions[bot]

Great! Thank you.

mulderje avatar Aug 30 '24 01:08 mulderje

Thanks again for your work here, @mulderje

This work has completed our QA process and I've merged it to the main branch; expect to see it in the next client release!

jprusik avatar Aug 30 '24 15:08 jprusik