clients
clients copied to clipboard
[PM-11329] [chore] Add "otp" TotpFieldNames array in autofill-constants.ts
Add "otp" TotpFieldNames array in autofill-constants.ts. Noticed on https://id.fedoraproject.org/login/
đī¸ Tracking
N/A
đ Objective
Add "otp" TotpFieldNames array in autofill-constants.ts. Noticed on https://id.fedoraproject.org/login/
As an aside, has a custom "linked" field been considered here like with passwords? I noticed at least one request on the forum, but couldn't find much here with a search.
đ¸ Screenshots
N/A
â° Reminders before review
- Contributor guidelines followed
- All formatters and local linters executed and passed
- Written new unit and / or integration tests where applicable
- Protected functional changes with optionality (feature flags)
- Used internationalization (i18n) for all UI strings
- CI builds passed
- Communicated to DevOps any deployment requirements
- Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team
đĻŽ Reviewer guidelines
- đ (
:+1:) or similar for great changes - đ (
:memo:) or âšī¸ (:information_source:) for notes or general info - â (
:question:) for questions - đ¤ (
:thinking:) or đ (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - đ¨ (
:art:) for suggestions / improvements - â (
:x:) or â ī¸ (:warning:) for more significant problems or concerns needing attention - đą (
:seedling:) or âģī¸ (:recycle:) for future improvements or indications of technical debt - â (
:pick:) for minor or nitpick changes
Thank you for your contribution! We've added this to our internal Community PR board for review. ID: PM-11329
Checkmarx One â Scan Summary & Details â 12bce8e0-f5f6-483d-9067-3cf7fe300ef4
New Issues
| Severity | Issue | Source File / Package | Checkmarx Insight |
|---|---|---|---|
![]() |
Unpinned Actions Full Length Commit SHA | /build-cli.yml: 402 | Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps... |
Fixed Issues
| Severity | Issue | Source File / Package |
|---|---|---|
![]() |
Unpinned Actions Full Length Commit SHA | /build-cli.yml: 405 |
![]() |
Client_DOM_Open_Redirect | /apps/web/src/connectors/common.ts: 2 |
![]() |
Client_DOM_Open_Redirect | /apps/web/src/connectors/common.ts: 2 |
![]() |
Client_DOM_Open_Redirect | /apps/web/src/connectors/common.ts: 2 |
![]() |
Client_Use_Of_Iframe_Without_Sandbox | /apps/browser/src/autofill/overlay/notifications/content/overlay-notifications-content.service.ts: 165 |
Great! Thank you.
Thanks again for your work here, @mulderje
This work has completed our QA process and I've merged it to the main branch; expect to see it in the next client release!

